Skip to content

fix(wasip1): fd_renumber panic in the adapter#11277

Merged
rvolosatovs merged 4 commits into
bytecodealliance:mainfrom
rvolosatovs:fix/fd-renumber-adapter
Jul 18, 2025
Merged

fix(wasip1): fd_renumber panic in the adapter#11277
rvolosatovs merged 4 commits into
bytecodealliance:mainfrom
rvolosatovs:fix/fd-renumber-adapter

Conversation

@rvolosatovs
Copy link
Copy Markdown
Member

@rvolosatovs rvolosatovs commented Jul 18, 2025

This a security advisory fix PR moved from https://github.com/bytecodealliance/wasmtime-ghsa-fm79-3f68-h2fc/pull/2

blocked on #11276

This reverts commit 00325ff36d44a3cf666085d56a7c80e907636d8b.
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
prtest:full

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs force-pushed the fix/fd-renumber-adapter branch from aa088cd to dc16106 Compare July 18, 2025 17:06
@rvolosatovs rvolosatovs marked this pull request as ready for review July 18, 2025 17:06
@rvolosatovs rvolosatovs requested review from a team as code owners July 18, 2025 17:06
@rvolosatovs rvolosatovs requested review from alexcrichton and removed request for a team July 18, 2025 17:06
@rvolosatovs rvolosatovs enabled auto-merge July 18, 2025 17:07
@rvolosatovs rvolosatovs added this pull request to the merge queue Jul 18, 2025
@rvolosatovs rvolosatovs removed this pull request from the merge queue due to a manual request Jul 18, 2025
@rvolosatovs rvolosatovs added this pull request to the merge queue Jul 18, 2025
Merged via the queue into bytecodealliance:main with commit aec935f Jul 18, 2025
165 checks passed
@rvolosatovs rvolosatovs deleted the fix/fd-renumber-adapter branch July 18, 2025 18:29
bongjunj pushed a commit to prosyslab/wasmtime that referenced this pull request Oct 20, 2025
* Revert "test(wasip1): ignore `fd_renumber` tests when using adapter"

This reverts commit 00325ff36d44a3cf666085d56a7c80e907636d8b.

* fix(wasip1-adapter): prevent `unreachable` panic on `fd_renumber`

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>

* doc: document adapter panic fix

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>

* doc: add PR reference

prtest:full

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>

---------

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasi Issues pertaining to WASI wasmtime:docs Issues related to Wasmtime's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants