Fix off-by-one error in enum discriminant validation#12356
Merged
Conversation
The discriminant check used `i32.gt_u` when it should use `i32.ge_u`. For an enum with N cases (valid discriminants 0 to N-1), a discriminant of exactly N was incorrectly accepted. Closes bytecodealliance#12354
alexcrichton
approved these changes
Jan 15, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks for this, and thanks for the test too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discriminant check used
i32.gt_uwhen it should usei32.ge_u. For an enum with N cases (valid discriminants 0 to N-1), a discriminant of exactly N was incorrectly accepted.Closes #12354