Skip to content

Share empty ModuleRuntimeInfos across all stores in an engine#12409

Merged
fitzgen merged 3 commits into
bytecodealliance:mainfrom
fitzgen:share-module-runtime-info
Jan 23, 2026
Merged

Share empty ModuleRuntimeInfos across all stores in an engine#12409
fitzgen merged 3 commits into
bytecodealliance:mainfrom
fitzgen:share-module-runtime-info

Conversation

@fitzgen
Copy link
Copy Markdown
Member

@fitzgen fitzgen commented Jan 23, 2026

This avoids an Arc- and Box-allocation during Store creation.

@fitzgen fitzgen requested a review from a team as a code owner January 23, 2026 18:42
@fitzgen fitzgen requested review from alexcrichton and removed request for a team January 23, 2026 18:42
This avoids an `Arc`- and `Box`-allocation during `Store` creation.
@fitzgen fitzgen force-pushed the share-module-runtime-info branch from d4f1a02 to ca673e1 Compare January 23, 2026 18:52
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh shoulda done this a long time ago, good catch!

@fitzgen fitzgen enabled auto-merge January 23, 2026 19:06
@fitzgen fitzgen added this pull request to the merge queue Jan 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2026
@fitzgen fitzgen added this pull request to the merge queue Jan 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2026
@github-actions github-actions Bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jan 23, 2026
@fitzgen fitzgen requested a review from a team as a code owner January 23, 2026 20:49
@fitzgen fitzgen requested review from dicej and removed request for a team January 23, 2026 20:49
@fitzgen fitzgen enabled auto-merge January 23, 2026 20:49
@fitzgen fitzgen added this pull request to the merge queue Jan 23, 2026
Merged via the queue into bytecodealliance:main with commit 17899c8 Jan 23, 2026
45 checks passed
@fitzgen fitzgen deleted the share-module-runtime-info branch January 23, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants