winch(aarch64): Remove side effect from shift kind to ALUOp calculation#12501
Merged
fitzgen merged 1 commit intoFeb 3, 2026
Merged
Conversation
Fixes bytecodealliance#12423 Prior to this commit, calculating the ALUOp for the rotate left operation included a negation side-effect on the rotate operands. In the case of shift with immediate, the implementation was wrongly performing the negation on the `rn` register rather than using the immediate value, which resulted in the mis-compilation described in the issue below. This commit ensures that the conversion from the shift kind to the ALUOp is side-effect free.
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12423
Prior to this commit, calculating the ALUOp for the rotate left operation included a negation side-effect on the rotate operands. In the case of shift with immediate, the implementation was wrongly performing the negation on the
rnregister rather than using the immediate value, which resulted in the miscompilation described in the issue below.This commit ensures that the conversion from the shift kind to the ALUOp is side-effect free.