Temporarily remove support for interface types#1292
Merged
alexcrichton merged 2 commits intoMar 12, 2020
Conversation
github-actions
Bot
added
the
wasmtime:api
fitzgen
approved these changes
Mar 11, 2020
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Looks good, suggested a little wordsmithing and typo fixing inline below
Subscribe to Label ActionThis issue or pull request has been labeled: "w", "a", "s", "m", "t", "i", "e", ":", "p" To subscribe or unsubscribe from this label, edit the |
This commit temporarily removes support for interface types from the `wasmtime` CLI and removes the `wasmtime-interface-types` crate. An error is now printed for any input wasm modules that have wasm interface types sections to indicate that support has been removed and references to two issues are printed as well: * bytecodealliance#677 - tracking work for re-adding interface types support * bytecodealliance#1271 - rationale for removal and links to other discussions Closes bytecodealliance#1271
alexcrichton
force-pushed
the
rm-interface-types
branch
from
a92a69d to
93ec8e9
Compare
This was referenced Mar 13, 2020
Rust example is an order of magnitude slower than wasmtime binary
bytecodealliance/wasmtime-demos#17
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit temporarily removes support for interface types from the
wasmtimeCLI and removes thewasmtime-interface-typescrate. Anerror is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:
Closes #1271