Add an instance API for invoking the WASI start functions.#1516
Closed
sunfishcode wants to merge 4 commits into
Closed
Add an instance API for invoking the WASI start functions.#1516sunfishcode wants to merge 4 commits into
sunfishcode wants to merge 4 commits into
Conversation
This adds support for the WASI reactor ABI proposed in WebAssembly/WASI#256, as well as the existing _start ABI for commands. This also implements the semantics that command instances should not persist after their _start function is called. As a safety measure, this includes a check that the instance refcount is 1, so that other references to the instance don't hold it live. Implementing that prompted a change to how the main Instance API works. Instead having instances eagerly compute a Vec of Externs, and bumping the refcount for each Extern, compute Externs on demand. This also means that the closure returned by `get0` and friends now holds an `InstanceHandle` to dynamically hold the instance live rather than being scoped to a lifetime.
github-actions
Bot
added
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
bjorn3
reviewed
Apr 15, 2020
Make `Module::exports` and `Module::imports` return iterators instead of slices, and compute them on demand rather than eagerly. Also, compute them from wasmtime_environ's data structures, rather than re-decoding the wasm bytes. To support this, change wasmtime_environ::Module hold a single imports array rather than having per-type arrays.
github-actions
Bot
added
the
fuzzing
Member
Author
|
Ok, I've now updated |
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
Author
|
Looking at where this PR ended up, there's a lot of refactoring here mixed in with a new feature, so I'm going to split this PR into pieces. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the WASI reactor ABI proposed in
WebAssembly/WASI#256, as well as the existing
_start ABI for commands.
This also implements the semantics that command instances should not
persist after their _start function is called. As a safety measure,
this includes a check that the instance refcount is 1, so that other
references to the instance don't hold it live.
Implementing that prompted a change to how the main Instance API works.
Instead having instances eagerly compute a Vec of Externs, and bumping
the refcount for each Extern, compute Externs on demand.
This also means that the closure returned by
get0and friends nowholds an
InstanceHandleto dynamically hold the instance live ratherthan being scoped to a lifetime.
This is a draft PR for now while I think more about whether this is a good
approach.