Implement 128bit legalizations for AArch64#1553
Closed
bjorn3 wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
cranelift
Subscribe to Label Actioncc @bnjbvr DetailsThis issue or pull request has been labeled: "cranelift"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
github-actions
Bot
added
the
cranelift:area:aarch64
github-actions
Bot
added
the
cranelift:area:machinst
Contributor
Author
|
#2538 is a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works by always using
legalize_function, but skipping the steps that are not necessary for the AArch64 backend.While
iaddis not yet legalized, as they it depends oniadd_ifcoutandiadd_ifcin, this does legalize many other 128bit integer operations and it supports function signatures with 128bit integers, making it much easier to support 128bit integers in cg_clif for the AArch64 backend.