Skip to content

Enable env_logger in the C API#1737

Merged
alexcrichton merged 1 commit into
bytecodealliance:masterfrom
alexcrichton:env-loger-c-api
May 21, 2020
Merged

Enable env_logger in the C API#1737
alexcrichton merged 1 commit into
bytecodealliance:masterfrom
alexcrichton:env-loger-c-api

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

This commit ensures that env_logger and RUST_LOG are configured to
work with the C API.

@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Member

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been drop-ing this type of call; should I be?

This commit ensures that `env_logger` and `RUST_LOG` are configured to
work with the C API.
@alexcrichton
Copy link
Copy Markdown
Member Author

Oh heh good point! I've added a comment.

The drop here isn't necessary in all cases, it's just our case where try_init fails after the first call, and it's expected that you should be able to call wasm_engine_new multiple times.

@alexcrichton alexcrichton merged commit 68f0d2f into bytecodealliance:master May 21, 2020
@alexcrichton alexcrichton deleted the env-loger-c-api branch May 21, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants