Skip to content

Move SingleFunctionCompiler into its own crate, cranelift-simplecompiler#1756

Closed
abrown wants to merge 1 commit into
bytecodealliance:mainfrom
abrown:simple-compiler
Closed

Move SingleFunctionCompiler into its own crate, cranelift-simplecompiler#1756
abrown wants to merge 1 commit into
bytecodealliance:mainfrom
abrown:simple-compiler

Conversation

@abrown
Copy link
Copy Markdown
Member

@abrown abrown commented May 26, 2020

While experimenting with using this together with cranelift-interpreter, I realized that having SingleFunctionCompiler in cranelift-filetests creates a circular dependency. Moving this functionality out to its own crate breaks that cycle. I am quite open to other approaches (merge together with simplejit somehow?) or crate name suggestions.

This is necessary to avoid dependency cycles between cranelift-filetests and cranelift-interpreter
@abrown abrown requested a review from sunfishcode May 26, 2020 03:08
@github-actions github-actions Bot added the cranelift Issues related to the Cranelift code generator label May 26, 2020
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @bnjbvr

Details This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@abrown
Copy link
Copy Markdown
Member Author

abrown commented May 26, 2020

cc: @alexcrichton, @yurydelendik: I saw that you were moving stuff around in wasmtime-jit in #1761 and wondered if you had any better ideas of where to put this SingleFunctionCompiler... it probably needs to stay in Cranelift-land but I'm checking just in case there is a better place it should go.

@alexcrichton
Copy link
Copy Markdown
Member

Ah I think #1761 is largely just juggling wasmtime data structures and the code produced by cranelift, so I don't think it's too too connected to this. As for how this is organized, I don't have too many opinions myself!

@alexcrichton alexcrichton changed the base branch from master to main June 25, 2020 18:49
@abrown
Copy link
Copy Markdown
Member Author

abrown commented Dec 8, 2020

Too old!

@abrown abrown closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants