impl WasmTy for u32 and u64#1808
Merged
alexcrichton merged 2 commits intoJun 4, 2020
Merged
Conversation
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
|
Agreed these are good to have, thanks! Some other items I think to take care of are:
|
Contributor
Author
|
@alexcrichton thanks for the review, I've addressed all points. |
Member
|
Looks great to me! As one final nit, there's a table under "Rust types will map to WebAssembly types as follows", mind adding the u32/u64 types there too? |
Contributor
Author
|
@alexcrichton ah of course, I missed that. Updated it. |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasm integer types are sign agnostic, so if Rust i32 and i64 are WasmTy so should u32 and u64. The trait implentation is exactly the same between i/u32 and i/u64.