Skip to content

Bind Trap::i32_exit_status in C API#1912

Merged
alexcrichton merged 1 commit into
bytecodealliance:masterfrom
alexcrichton:c-api-i32-status
Jun 23, 2020
Merged

Bind Trap::i32_exit_status in C API#1912
alexcrichton merged 1 commit into
bytecodealliance:masterfrom
alexcrichton:c-api-i32-status

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

This allows embedders to take a different action when a WASI program
exits depending on whether it exited with an exit status or exited with
a trap.

cc bytecodealliance/wasmtime-py#30

This allows embedders to take a different action when a WASI program
exits depending on whether it exited with an exit status or exited with
a trap.

cc bytecodealliance/wasmtime-py#30
@github-actions github-actions Bot added the wasmtime:c-api Issues pertaining to the C API. label Jun 23, 2020
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@sunfishcode
Copy link
Copy Markdown
Member

This looks good to me. In the future we'll have other kinds of exit values, so this API may need to be generalized, but this works for now.

@alexcrichton alexcrichton merged commit 6f62968 into bytecodealliance:master Jun 23, 2020
@alexcrichton alexcrichton deleted the c-api-i32-status branch June 23, 2020 16:40
jedisct1 pushed a commit to jedisct1/wasmtime-crypto that referenced this pull request Jul 2, 2020
This allows embedders to take a different action when a WASI program
exits depending on whether it exited with an exit status or exited with
a trap.

cc bytecodealliance/wasmtime-py#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants