machinst x64: a few small opts#2277
Merged
Merged
Conversation
github-actions
Bot
added
cranelift
cfallin
approved these changes
Oct 8, 2020
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Looks good, thanks!
I'm not wild about the amount of special-cased logic that's accumulating relating to value widths and zero/sign-extends; in the future I hope to build a more general analysis/framework that will solve this problem more generally. But for now, it's a generated-code win, and it works, so let's go for it.
julian-seward1
approved these changes
Oct 9, 2020
julian-seward1
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I'd like to test it a bit more before considering review, but: this already enhances the code quality a bit on some hot blocks identified with Valgrind.)