wasmtime-wasi usability: re-exports of common siblings#2776
Merged
Conversation
this drops the direct dep on wasi-cap-std-sync and wasi-common.
pchickey
force-pushed
the
pch/wasmtime_wasi_usability
branch
from
c5d6c3f to
af70301
Compare
github-actions
Bot
added
wasi
Subscribe to Label Actioncc @kubkon, @peterhuene DetailsThis issue or pull request has been labeled: "wasi", "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until more impls come along, every user of
wasmtime-wasiis going to usewasi-cap-std-syncas theirWasiCtxBuilder. Rather than make our users track a dependency on an additional crate, re-export it under the top-levelsyncmodule.This re-export sits behind the
syncCargo feature, which is enabled by default. Users who want to opt out of these re-exports can disable default-features.Additionally,
wasi-cap-std-syncnow re-exports thecap_std::fs::Dirtype that it consumes inWasiCtxBuilder::preopened_dir. Again, just keeps the consumers of these crates from tracking another dep version.And finally I cleaned up those extra deps for the wasmtime cli.