Skip to content

Switch fuzzers to use new Cranelift backend.#2779

Closed
cfallin wants to merge 1 commit into
bytecodealliance:mainfrom
cfallin:fuzz-new-backend
Closed

Switch fuzzers to use new Cranelift backend.#2779
cfallin wants to merge 1 commit into
bytecodealliance:mainfrom
cfallin:fuzz-new-backend

Conversation

@cfallin
Copy link
Copy Markdown
Member

@cfallin cfallin commented Mar 26, 2021

As per bytecodealliance/rfcs#10, the first step in our transition to the
new Cranelift x86-64 backend by default in Wasmtime is to switch our
fuzzers and monitor for any breakage.

This PR moves all Wasmtime fuzz targets over to use the new backend. The
differential old-vs-new-backend target still works by dynamically
selecting both backends (the build feature just changes the default,
which is what all the other fuzz targets use).

We should watch for ~a week or so, I think, on oss-fuzz, to make sure
this sticks without issue before moving further.

As per bytecodealliance/rfcs#10, the first step in our transition to the
new Cranelift x86-64 backend by default in Wasmtime is to switch our
fuzzers and monitor for any breakage.

This PR moves all Wasmtime fuzz targets over to use the new backend. The
differential old-vs-new-backend target still works by dynamically
selecting both backends (the build feature just changes the default,
which is what all the other fuzz targets use).

We should watch for ~a week or so, I think, on oss-fuzz, to make sure
this sticks without issue before moving further.
@cfallin cfallin requested a review from alexcrichton March 26, 2021 16:34
@github-actions github-actions Bot added the fuzzing Issues related to our fuzzing infrastructure label Mar 26, 2021
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@cfallin
Copy link
Copy Markdown
Member Author

cfallin commented Mar 26, 2021

Hmm, the test failure seems to indicate that the feature is leaking and turning on the new backend in other tests -- I don't claim to fully understand the new feature resolver, any thoughts @alexcrichton? Digging in further.

@bjorn3
Copy link
Copy Markdown
Contributor

bjorn3 commented Mar 26, 2021

I don't think Wasmtime has switched to the new resolver yet. You need to add

[workspace]
resolver = "2"

to the top-level Cargo.toml to enable it.

@alexcrichton
Copy link
Copy Markdown
Member

Given Cargo's behavior to unify features I don't think it will be easy to have a specific default per component of wasmtime in our CI like this.

I think if we want to do this we should probably do the switch here -- https://github.com/google/oss-fuzz/blob/54f0985f8ed3055e1bbfa19eb2f67623cf952162/projects/wasmtime/build.sh#L59-L63. This would have to update that anyway since the feature is going away too.

@cfallin
Copy link
Copy Markdown
Member Author

cfallin commented Mar 26, 2021

Hmm, yes, that's probably the better option. I'll go ahead and create a PR over there. Thanks!

@cfallin cfallin closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fuzzing Issues related to our fuzzing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants