Skip to content

Fix srem.{i8,i16}#2828

Merged
cfallin merged 1 commit into
bytecodealliance:mainfrom
bjorn3:fix_srem_i8
Apr 13, 2021
Merged

Fix srem.{i8,i16}#2828
cfallin merged 1 commit into
bytecodealliance:mainfrom
bjorn3:fix_srem_i8

Conversation

@bjorn3
Copy link
Copy Markdown
Contributor

@bjorn3 bjorn3 commented Apr 13, 2021

Fixes one half of #2826.

@bjorn3
Copy link
Copy Markdown
Contributor Author

bjorn3 commented Apr 13, 2021

Doc failure is unrelated.

@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Apr 13, 2021
@bjorn3
Copy link
Copy Markdown
Contributor Author

bjorn3 commented Apr 13, 2021

Nightly seems to break things.

Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin
Copy link
Copy Markdown
Member

cfallin commented Apr 13, 2021

Just fixed CI in #2830 -- if you rebase on top of that, I think CI should be fixed here.

@cfallin cfallin merged commit f222802 into bytecodealliance:main Apr 13, 2021
@bjorn3 bjorn3 deleted the fix_srem_i8 branch April 14, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants