Skip to content

Add back support for accumulating outgoing arguments#2837

Merged
cfallin merged 1 commit into
bytecodealliance:mainfrom
uweigand:outgoing-args
Apr 14, 2021
Merged

Add back support for accumulating outgoing arguments#2837
cfallin merged 1 commit into
bytecodealliance:mainfrom
uweigand:outgoing-args

Conversation

@uweigand
Copy link
Copy Markdown
Member

The unwind rework (commit 2d5db92) removed support for the
feature to allow a target to allocate the space for outgoing
function arguments right in the prologue (originally added
via commit 80c2d70). This patch adds it back.

The unwind rework (commit 2d5db92) removed support for the
feature to allow a target to allocate the space for outgoing
function arguments right in the prologue (originally added
via commit 80c2d70).   This patch adds it back.
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen labels Apr 14, 2021
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cfallin cfallin merged commit 36c667d into bytecodealliance:main Apr 14, 2021
@uweigand uweigand deleted the outgoing-args branch April 14, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants