debug: Avoid underflow when scanning for landing pad bytes#2866
Merged
Conversation
26 tasks
Member
|
Do you know if it would be possible to add a test for this? |
Member
Author
|
Unfortunately, it's a very very large module, hard to break up. If you've got a tool or a magic command line that can take the wat and automatically reduce it, I'm willing to try it. Unfortunately I don't know enough about this code so as to be able to craft a test case from scratch. |
Member
|
Ah ok, seems fine then! |
Contributor
|
You could try creduce on the |
mchesser
pushed a commit
to mchesser/wasmtime
that referenced
this pull request
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really know what I'm doing here, but bear with me... This landing pad bytes scanning assumes at least 2 bytes in the given buffer, but in a local test case I was trying against, the buffer was empty, so 0 bytes, so the subtract would underflow. Just adding this guard seems to make it work-ish -- I don't get full variable inspection power, but I expect that this is unrelated to my change.