Implement simple benchmarks for instantiation.#2900
Merged
peterhuene merged 1 commit intoMay 17, 2021
Conversation
Member
Author
|
Note: as the pooling/uffd allocator requires multiple instantiations from the same engine instance, these benchmarks were not implemented with sightglass yet. |
Member
|
(I'm just waiting to see if cargo-deny blows up like it did for me over in #2888...) |
Member
Author
|
It did indeed :) There's no rush on merging this, so I'll do so after your PR goes in. |
alexcrichton
approved these changes
May 12, 2021
Member
|
FWIW from CI: |
Member
|
#2888 is merged so perhaps a rebase would make the CI go green (I kicked off the CI in case that works...). |
This adds benchmarks around module instantiation using criterion. Both the default (i.e. on-demand) and pooling allocators are tested sequentially and in parallel using a thread pool. Instantiation is tested with an empty module, a module with a single page linear memory, a larger linear memory with a data initializer, and a "hello world" Rust WASI program.
65b71e5 to
1b8efa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds benchmarks around module instantiation using criterion.
Both the default (i.e. on-demand) and pooling allocators are tested
sequentially and in parallel using a thread pool.
Instantiation is tested with an empty module, a module with a single page
linear memory, a larger linear memory with a data initializer, and a "hello
world" Rust WASI program.