Add support for Saturating Rounding Q-format Multiplication for x64#3105
Merged
jlb6740 merged 1 commit intoJul 27, 2021
Merged
Conversation
jlb6740
force-pushed
the
implement-sat-int-q-round-mul
branch
from
29ae1d6 to
9dccfe1
Compare
github-actions
Bot
added
cranelift
jlb6740
force-pushed
the
implement-sat-int-q-round-mul
branch
from
9dccfe1 to
28642b3
Compare
cfallin
approved these changes
Jul 26, 2021
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
LGTM apart from the accidental (?) removal of movdqa below and some comment nits. Thanks!
jlb6740
force-pushed
the
implement-sat-int-q-round-mul
branch
from
28642b3 to
14a25fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.