Update to regalloc.rs 0.0.32.#3466
Merged
Merged
Conversation
It appears that some allocation heuristics have changed slightly since 0.0.31, so some of the golden-output filetests are updated as well. Ideally we would rely more on runtests rather than golden-compilation tests; but for now this is sufficient. (I'm not sure exactly what in regalloc.rs changed to alter these heuristics; it's actually been almost a year since the 0.0.31 release with several refactorings and tweaks merged since then.) Fixes bytecodealliance#3441.
fitzgen
approved these changes
Oct 20, 2021
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in a change from regalloc.rs to address some quadratic behavior
(thanks @adamrk!).
It appears that some allocation heuristics have changed slightly since
0.0.31, so some of the golden-output filetests are updated as well.
Ideally we would rely more on runtests rather than golden-compilation
tests; but for now this is sufficient. (I'm not sure exactly what in
regalloc.rs changed to alter these heuristics; it's actually been almost
a year since the 0.0.31 release with several refactorings and tweaks
merged since then.)
Fixes #3441.