cranelift: Port ushr SIMD lowerings to ISLE on x64#3688
Merged
Conversation
fitzgen
force-pushed
the
ushr-simd-isle
branch
2 times, most recently
from
1cf4489 to
ed3006a
Compare
cfallin
approved these changes
Jan 13, 2022
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Looks good, thanks! Much clearer to read with all the cases split out :-)
fitzgen
force-pushed
the
ushr-simd-isle
branch
from
ed3006a to
f90e9d8
Compare
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
Author
|
Hm it looks like the |
Member
|
Oh that looks like a Rust 1.58.0 thing which was just released most likely, probably unrelated to this PR |
fitzgen
force-pushed
the
ushr-simd-isle
branch
from
f90e9d8 to
4e34dd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.