feat: remove the limitation of either R or W polls#3866
Merged
Conversation
Allow polls on read _and_ write. Signed-off-by: Harald Hoyer <harald@profian.com>
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
haraldh
added a commit
to haraldh/mio
that referenced
this pull request
Mar 1, 2022
Given, that wasmtime was fixed with bytecodealliance/wasmtime#3866 then we can poll on POLLIN and POLLOUT with multiple subscriptions. Signed-off-by: Harald Hoyer <harald@profian.com>
Contributor
|
It appears that 7a1b7cd changed this code from the Poll structure holding mutable refs to a WasiFile to having a shared ref, so this used-at-most-once check is no longer necessary. |
pchickey
approved these changes
Mar 1, 2022
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
This code was made unnecessary by the RFC11 refactor but we didn't catch it during code review.
sunfishcode
approved these changes
Mar 1, 2022
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
I agree. With the way __wasi_poll_oneoff currently works, it should be able to handle the same file descriptor appearing multiple times.
Contributor
|
Thanks @haraldh ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow polls on read and write.
See also tokio-rs/mio#1549 (comment)
Why was this limitation added?
Signed-off-by: Harald Hoyer harald@profian.com