bench-api: configure WASI modules based on passed flags#4207
Merged
Conversation
fitzgen
approved these changes
Jun 2, 2022
Contributor
|
Looks good to me @abrown , thanks. |
jameysharp
approved these changes
Sep 23, 2022
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
This seems like a good idea to me!
When benchmarking in Sightglass, @brianjjones has found it necessary to enable the wasi-nn module. The current way to do so is to alter the engine build script to pass `--features wasi-nn` so that this crate can run code relying on these imports. This change allows the user to instead pass the WASI modules using the engine flags added in bytecodealliance#4096. This could look something like the following in Sightglass: ``` sightglass-cli benchmark ... --engine-flags '--wasi-modules experimental-wasi-nn' ```
abrown
force-pushed
the
bench-wasi-flags
branch
from
507b376 to
f76e439
Compare
Member
Author
|
Looks like the build is passing fine now; merging... |
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
Sep 25, 2022
This fixes a compile-time error introduced in bytecodealliance#4207. The `?` operator doesn't work inside `Option::map` because it tries to return from the inner closure, not the outer function. Apparently our CI doesn't build wasmtime-bench-api so it didn't catch this issue.
abrown
pushed a commit
that referenced
this pull request
Sep 26, 2022
This fixes a compile-time error introduced in #4207. The `?` operator doesn't work inside `Option::map` because it tries to return from the inner closure, not the outer function. Apparently our CI doesn't build wasmtime-bench-api so it didn't catch this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When benchmarking in Sightglass, @brianjjones has found it necessary to
enable the wasi-nn module. The current way to do so is to alter the
engine build script to pass
--features wasi-nnso that this crate canrun code relying on these imports. This change allows the user to
instead pass the WASI modules using the engine flags added in #4096.
This could look something like the following in Sightglass: