Use Cargo's "namespace features" feature#4293
Merged
alexcrichton merged 1 commit intoJun 21, 2022
Merged
Conversation
Cargo recently added the ability to have an optional dependency without implicitly introducing a new named feature on a crate. This is triggered with some new directives in the `[features]` section, specifically: * The `dep:foo` syntax means that `foo` is activated but no implicit feature should be added named `foo`. * Additionally `foo?/bar` means that the `bar` feature of `foo` is only activated if `foo` is otherwise activated elsewhere, for example a conditional activation. These two features can help avoid extra feature names showing up that we don't want (e.g. currently the `wasmtime` crate has a `rayon` feature) and additionally can help avoid runtime dependencies in niche cases for us (e.g. activating `all-arch` but disabling `cranelift` would previously pull-in cranelift but no longer will).
github-actions
Bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo recently added the ability to have an optional dependency without
implicitly introducing a new named feature on a crate. This is triggered
with some new directives in the
[features]section, specifically:The
dep:foosyntax means thatfoois activated but no implicitfeature should be added named
foo.Additionally
foo?/barmeans that thebarfeature offoois onlyactivated if
foois otherwise activated elsewhere, for example aconditional activation.
These two features can help avoid extra feature names showing up that we
don't want (e.g. currently the
wasmtimecrate has arayonfeature)and additionally can help avoid runtime dependencies in niche cases for
us (e.g. activating
all-archbut disablingcraneliftwouldpreviously pull-in cranelift but no longer will).