Cherry-pick #4332 to 0.38 branch.#4336
Merged
alexcrichton merged 2 commits intoJun 27, 2022
Merged
Conversation
alexcrichton
approved these changes
Jun 27, 2022
Member
|
@cfallin if you want to rebase this one I think it should be good to merge |
…tecodealliance#4332) `idiv` on x86-64 only reads `rdx`/`edx`/`dx`/`dl` for divides with width greater than 8 bits; for an 8-bit divide, it reads the whole 16-bit divisor from `ax`, as our CISC ancestors intended. This PR fixes the metadata to avoid a regalloc panic (due to undefined `rdx`) in this case. Does not affect Wasmtime or other Wasm-frontend embedders.
cfallin
force-pushed
the
update-0.38.0-idiv8
branch
from
604f1e7 to
3d527fb
Compare
Member
Author
|
Rebased, will merge once tests are green. |
Member
|
Given the green status on #4332 and the prior green status on #4333 for the release-0.38.0 branch I'm actually gonna go ahead and merge this to help reduce our CI load a bit (which is a bit overloaded at the moment...). I'll wait for the full green sign off on #4339 which I will subsequently rebase over this and put the final touches on the release notes there (mostly the simd fixes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of the fix in #4332, which we want to ride along with our other register allocator-related fix in the point release in order to fully address the reported issues from cg_clif.