Don't try to report file size or timestamps for stdio streams.#4531
Merged
Conversation
Calling `File::metadata()` on a stdio stream handle fails on Windows, where the stdio streams are not files. This `File::metadata()` call was effectively only being used to add file size and timestamps to the result of `filestat_get`. It's common for users to redirect stdio streams to interesting places, and applications generally shouldn't change their behavior depending on the size or timestamps of the file, if the streams are redirected to a file, so just leave these fields to 0, which is commonly understood to represent "unknown". Fixes bytecodealliance#4497.
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Jul 26, 2022
yamt
added a commit
to yamt/wasi-testsuite
that referenced
this pull request
Feb 28, 2023
Because it seems testing something very specific to wasmtime. cf. bytecodealliance/wasmtime#4531
yamt
added a commit
to yamt/WASI
that referenced
this pull request
Apr 7, 2023
sunfishcode
pushed a commit
to WebAssembly/WASI
that referenced
this pull request
Jul 19, 2023
loganek
pushed a commit
to WebAssembly/wasi-testsuite
that referenced
this pull request
Aug 29, 2023
Because it seems testing something very specific to wasmtime. cf. bytecodealliance/wasmtime#4531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
File::metadata()on a stdio stream handle fails on Windows, wherethe stdio streams are not files.
This
File::metadata()call was effectively only being used to add file sizeand timestamps to the result of
filestat_get. It's common for users toredirect stdio streams to interesting places, and applications
generally shouldn't change their behavior depending on the size or
timestamps of the file, if the streams are redirected to a file, so just
leave these fields to 0, which is commonly understood to represent
"unknown".
Fixes #4497.