cranelift: Build a runtest case from fuzzer TestCase's#4590
Merged
Conversation
jameysharp
approved these changes
Aug 9, 2022
Contributor
Author
|
Now with a default expected output! However the test case still doesn't execute by default, since we don't support |
jameysharp
suggested changes
Aug 9, 2022
8d397bd to
63c2a9e
Compare
auto-merge was automatically disabled
August 10, 2022 19:35
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This is a quality of life improvement for the fuzzer. With the custom
Debugimpl we build a runtest test case that automatically executes in the interpreter and in the compiler backend.The test case needs some changes in order to be actually executable, since we don't know what the expected output of the function is. But an improvement in the future could be to run the interpreter in the
Debugimpl and print those results as the expected.The big thing here is that it also formats floats correctly, which with the previous impl we a pain to get into a runtest since they were printed in integer format.
Here's an example output:
cc: @jameysharp