Stop returning NOTCAPABLE errors from WASI calls.#4666
Merged
sunfishcode merged 3 commits intoAug 10, 2022
Conversation
`ENOTCAPABLE` was an error code that is used as part of the rights system, from CloudABI. There is a set of flags associated with each file descriptor listing which operations can be performed with the file descriptor, and if an attempt is made to perform an operation with a file descriptor that isn't permitted by its rights flags, it fails with `ENOTCAPABLE`. WASI is removing the rights system. For example, WebAssembly/wasi-libc#294 removed support for translating `ENOTCAPABLE` into POSIX error codes, on the assumption that engines should stop using it. So as another step to migrating away from the rights system, remove uses of the `ENOTCAPABLE` error.
sunfishcode
force-pushed
the
stop-using-notcapable
branch
from
0ccfbbb to
7138042
Compare
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
jameysharp
approved these changes
Aug 10, 2022
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
I've made suggestions that I think are easier to read at a glance because they don't duplicate the context calls (bonus, they're one line shorter in each case) but this looks good to me either way.
Co-authored-by: Jamey Sharp <jamey@minilop.net>
Co-authored-by: Jamey Sharp <jamey@minilop.net>
Member
Author
|
Good call, I applied both your suggestions 😄. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENOTCAPABLEwas an error code that is used as part of the rightssystem, from CloudABI. There is a set of flags associated with each file
descriptor listing which operations can be performed with the file
descriptor, and if an attempt is made to perform an operation with a
file descriptor that isn't permitted by its rights flags, it fails with
ENOTCAPABLE.WASI is removing the rights system. For example, WebAssembly/wasi-libc#294
removed support for translating
ENOTCAPABLEinto POSIX error codes, onthe assumption that engines should stop using it.
So as another step to migrating away from the rights system, remove uses
of the
ENOTCAPABLEerror.