cranelift: Add Rotates to fuzzer#4696
Merged
Merged
Conversation
jameysharp
approved these changes
Aug 11, 2022
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
But not shifts yet, huh? Well, that's okay, this is clearly an improvement.
FYI, I won't be reviewing more until Monday, so don't push more to this branch after I've turned on auto-merge or it probably won't go in until I'm back. 😅
Contributor
Author
|
I'm working on shifts now! We still don't fully support I128 shifts, but I was thinking of filing a issue and commiting it with the i128 cases commented out. I'll do that as a separate PR though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
Now that #4519 is merged, we can add rotates to the fuzzer!
cc: @jameysharp