Skip to content

[cranelift] Re-add missing blanket implementations for &mut Module#4719

Merged
jameysharp merged 1 commit into
mainfrom
readd-module-self-mut-method-impl
Aug 16, 2022
Merged

[cranelift] Re-add missing blanket implementations for &mut Module#4719
jameysharp merged 1 commit into
mainfrom
readd-module-self-mut-method-impl

Conversation

@bnjbvr
Copy link
Copy Markdown
Member

@bnjbvr bnjbvr commented Aug 16, 2022

Thanks to @bjorn3 who reported this had disappeared during #4551.

@bnjbvr bnjbvr mentioned this pull request Aug 16, 2022
Open
26 tasks
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:module labels Aug 16, 2022
bjorn3
bjorn3 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jameysharp
jameysharp approved these changes Aug 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@jameysharp jameysharp merged commit 2ce03cc into main Aug 16, 2022
@jameysharp jameysharp deleted the readd-module-self-mut-method-impl branch August 16, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jameysharp jameysharp jameysharp approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cranelift:module cranelift Issues related to the Cranelift code generator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bnjbvr @jameysharp @bjorn3