Port vconst to ISLE (AArch64)#4750
Merged
Merged
Conversation
Ported the existing implementation of `vconst` to ISLE for AArch64, and added support for 64-bit vector constants. Also introduced 64-bit `vconst` support to the interpreter. Copyright (c) 2022 Arm Limited
github-actions
Bot
added
cranelift
cfallin
approved these changes
Aug 22, 2022
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Thanks! A series of cleanup nits (or really one nit, repeated) below but otherwise LGTM.
Copyright (c) 2022 Arm Limited
cfallin
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported the existing implementation of
vconstto ISLE for AArch64, andadded support for 64-bit vector constants.
Also introduced 64-bit
vconstsupport to the interpreter.Copyright (c) 2022 Arm Limited