Port Fcopysign..FcvtToSintSat to ISLE (AArch64)#4753
Merged
Conversation
dheaton-arm
force-pushed
the
isle-fpcvt
branch
from
02f176b to
269240f
Compare
github-actions
Bot
added
cranelift
dheaton-arm
changed the title
FcvtToUint..`FcvtToSintSat to ISLE (AArch64)Fcopysign..`FcvtToSintSat to ISLE (AArch64)
dheaton-arm
changed the title
Fcopysign..`FcvtToSintSat to ISLE (AArch64)Fcopysign..FcvtToSintSat to ISLE (AArch64)
cfallin
reviewed
Aug 23, 2022
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Thanks!
I have some thoughts below on a possible refactor but if it's too onerous, we can skip (the side-effecting emits are in inst.isle alongside other emitter-helpers so it's not strictly necessary to fix I think).
Ported the existing implementations of the following opcodes to ISLE on
AArch64:
- `Fcopysign`
- Also introduced missing support for `fcopysign` on vector values, as
per the docs.
- This introduces the vector encoding for the `SLI` machine
instruction.
- `FcvtToUint`
- `FcvtToSint`
- `FcvtFromUint`
- `FcvtFromSint`
- `FcvtToUintSat`
- `FcvtToSintSat`
Copyright (c) 2022 Arm Limited
dheaton-arm
force-pushed
the
isle-fpcvt
branch
from
96da208 to
74fee50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported the existing implementations of the following opcodes to ISLE on
AArch64:
Fcopysignfcopysignon vector values, asper the docs.
SLImachineinstruction.
FcvtToUintFcvtToSintFcvtFromUintFcvtFromSintFcvtToUintSatFcvtToSintSatCopyright (c) 2022 Arm Limited