Implement I/O timeouts that specify the REALTIME clock.#4777
Merged
sunfishcode merged 1 commit intoAug 25, 2022
Conversation
POSIX specifies that functions like `nanosleep` use the REALTIME clock, so allow WASI `poll_oneoff` calls to use the REALTIME clock, at least for non-absolute intervals. POSIX specifies that the timeouts should not be affected by subsequent `clock_settime` calls, so they behave the same way as MONOTONIC clock requests, so we can implement them as monotonic requests.
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX specifies that functions like
nanosleepuse the REALTIME clock,so allow WASI
poll_oneoffcalls to use the REALTIME clock, at leastfor non-absolute intervals. POSIX specifies that the timeouts should not
be affected by subsequent
clock_settimecalls, so they behave the sameway as MONOTONIC clock requests, so we can implement them as monotonic
requests.