x64: Lower tlsvalue, sqmul_round_sat, and uunarrow in ISLE#4793
Merged
Conversation
github-actions
Bot
added
cranelift
cfallin
approved these changes
Aug 26, 2022
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
LGTM with the Uunarrow handwritten code removed, which we just discussed :-)
Thanks for the substantial work in moving all the ISLE lowerings over on x64, and finding/fixing issues along the way -- I'm super-happy to see the last ones gone here!
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
elliottt
force-pushed
the
trevor/x64-tlsvalue
branch
2 times, most recently
from
d075f40 to
f04cca3
Compare
elliottt
force-pushed
the
trevor/x64-tlsvalue
branch
from
f04cca3 to
919f2da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower
tlsvalue,sqmul_round_sat, anduunarrowin ISLE.