cranelift: Prepare fuzzgen for AArch64#4867
Merged
Merged
Conversation
github-actions
Bot
added
the
cranelift
32 tasks
Contributor
|
Assuming nobody objects to #4879, you should be able to remove the IntCC changes from this PR, so I want to see if anybody raises any concerns about that tomorrow before reviewing this. |
afonso360
force-pushed
the
fuzzgen-aarch64
branch
from
ca35541 to
fb1b8d0
Compare
Contributor
Author
|
I've rebased this on Edit: 3h so far, nothing has come up, should be good to merge. |
jameysharp
approved these changes
Sep 14, 2022
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
This includes a couple of input format changes that affect x86-64, but we don't currently have any open fuzz bugs, so I'm merging it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This disables some operations for AArch64 for fuzzgen. And uses
cfg's to disable ops instead of commenting them out, this makes it easier to run fuzzgen on a new arch by enabling all ops by default until we know they are broken.Also changes inputs for x86 since we enable
icmp.i128for some IntCC's which were previously all disabled.This ran for about an hour on x86 and aarch64 without crashing. (In conjunction with #4866 for aarch64)