Skip to content

Port icmp to ISLE (AArch64)#4898

Merged
cfallin merged 2 commits into
bytecodealliance:mainfrom
dheaton-arm:isle-icmp
Sep 13, 2022
Merged

Port icmp to ISLE (AArch64)#4898
cfallin merged 2 commits into
bytecodealliance:mainfrom
dheaton-arm:isle-icmp

Conversation

@dheaton-arm
Copy link
Copy Markdown
Contributor

Ported the existing implementation of icmp (and, by extension, the lower_icmp function) to ISLE for AArch64.

Copyright (c) 2022 Arm Limited

Ported the existing implementation of `icmp` (and, by extension, the
`lower_icmp` function) to ISLE for AArch64.

Copyright (c) 2022 Arm Limited
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Sep 12, 2022
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @cfallin, @fitzgen

Details This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Comment thread cranelift/codegen/src/isa/aarch64/inst.isle Outdated
Copyright (c) 2022 Arm Limited
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cfallin cfallin merged commit e9b08b8 into bytecodealliance:main Sep 13, 2022
@dheaton-arm dheaton-arm deleted the isle-icmp branch September 13, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants