feat: provide default methods for WasiDir#5019
Merged
Merged
Conversation
When implementing custom WasiDir instances, there is a lot of boilerplate. These default methods should reduce code for implementors who want to provide only a subset of functionality. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
|
To be sure, the vision for this code is that users will primarily write APis in wit, rather than encoding non-directory-like APIs within That said, I recognize that wit isn't ready to take on all use cases yet, so this makes sense for now. |
Member
Author
|
@sunfishcode I think you meant to merge this but just enabled auto-merge instead. :) |
sunfishcode
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing custom WasiDir instances, there is a lot of boilerplate. These default methods should reduce code for implementors who want to provide only a subset of functionality.