component model: async host function & embedding support#5055
Conversation
github-actions
Bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
I've double-checked bits and pieces internally and I think this should generally be good to go. I'm always somewhat wary of async since it's got unsafe underpinnings with fibers and whatnot but I'm at least for now confident enough in this that I'd be happy to merge. |
|
Thanks! I just need to write some tests. |
pchickey
force-pushed
the
pch/component_model_async
branch
from
99cefae to
b52f4ae
Compare
… accepting a closure We find that this makes the Linker::func_wrap type signature much easier to read. The IntoComponentFunc abstraction was adding a lot of weight to "splat" a set of arguments from a tuple of types into individual arguments to the closure. Additionally, making the StoreContextMut argument optional, or the Result<return> optional, wasn't very worthwhile.
github-actions
Bot
added
the
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
| store.0.async_support(), | ||
| "cannot use `call_async` without enabling async support in the config" | ||
| ); | ||
| store.on_fiber(|store| self.post_return_impl(store)).await? |
There was a problem hiding this comment.
One day in the future it might be best to conditionally do the fiber business here since many functions might not have a post_return in which case going through all this for a stack is largely overkill. Put another way the stack is only needed here for the crate::Func::call_unchecked_raw call, but this is an optimization we can deal with later.
| (component | ||
| (type $f (func)) | ||
| (type $imports_type | ||
| (instance | ||
| (alias outer 1 0 (type $f)) | ||
| (export "i" (func $f)) | ||
| ) | ||
| ) | ||
| (import "imports" (instance $imports (type $imports_type))) | ||
|
|
||
| (core module $m | ||
| (import "imports" "i" (func $i)) | ||
| (func (export "thunk") call $i) | ||
| ) | ||
|
|
||
| (alias export 0 "i" (func $f)) | ||
| (core func $f_lowered (canon lower (func 0))) | ||
| (core instance $imports_core (export "i" (func $f_lowered))) | ||
| (core instance $i (instantiate $m | ||
| (with "imports" (instance $imports_core)))) | ||
| (func (export "thunk") | ||
| (canon lift (core func $i "thunk")) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
You can simplify this a bit with:
(component
(import "i" (func $f))
(core module $m
(import "" "" (func $i))
(func (export "thunk") call $i)
)
(core func $f (canon lower (func $f)))
(core instance $i (instantiate $m
(with "" (instance
(export "" (func $f))
))
))
(func (export "thunk")
(canon lift (core func $i "thunk"))
)
)
pchickey
force-pushed
the
pch/component_model_async
branch
from
e867329 to
2f88f68
Compare
2 participants
Based on #5065.
This PR adds the async suite of variations on
Linker::wrap_func,Func::call,TypedFunc::call, and the variousinstantiatefunctions, for use in async Rust contexts.This ends up being pretty simple: all of the async store machinery from core wasmtime is straightforward to reuse here.
I created a new test suite at
tests/all/component_model/async.rsto smoke test the new functionality.