Fix some egraph-related issues.#5088
Merged
Merged
Conversation
github-actions
Bot
added
cranelift
elliottt
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5086 by addressing two separate issues:
ValueDataPacked::set_type()helper had an embarrassing bitfield-manipulation bug that would mangle the rest of aValueDefwhen setting its type. This is not normally used, only when the egraph elaboration fills in types after-the-fact on a multi-value node.ispliton aarch64 and s390x were dispatching on the first output type, rather than the input type. When only the second output is used (as in the example in Cranelift:ushr+isplitmiscompilation with egraphs #5086), the first output type actually remainsINVALID(and this is fine because it's never used).