wiggle: make wasmtime a mandatory dep, get rid of own Trap enum#5137
Merged
Conversation
added 5 commits
October 26, 2022 13:35
this existed so we could use wiggle in lucet, but lucet is long EOL
formally add a dependency on wasmtime here to make it obvious, though we do now have a transitive one via wiggle no matter what (and therefore can get rid of the default-features=false on the wiggle dep)
there's no way the implementation of this func is actually a good idea, it will panic the host process on any error, but I'll ask @mtr to fix that
alexcrichton
approved these changes
Oct 26, 2022
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
added 3 commits
October 26, 2022 15:21
this was originally for the WASI polyfill for web targets. Those days are way behind us now.
alexcrichton
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wiggle (& wasi-common) did a fair bit of cargo feature & other gymnastics to support Lucet and Wasmtime simultaneously. Supporting Lucet is no longer a concern, so I erased the cargo features that made wasmtime support optional in these crates, and got rid of the intermediate
wiggle::Trapenum, usingwasmtime::Trapdirectly instead.Note this means wasi-common will no longer build for
wasm32-unknown-emscriptennorarmv7-unknown-linuxbecause it depends onwasmtime. The emscripten used to build for that target to support a web polyfill, but we haven't maintained that polyfill in years and are fine with dropping that support. I have no idea what the armv7 target was used for. These targets were enforced in CI for a long time, and I deleted the CI job that checks for them.We will be adding component support to wasi-common shortly, which will also incur a direct wasmtime dep in that crate, so those targets were going to be broken pretty soon anyway. I hope that this doesn't cause too much grief for anyone.