c-api: add wasi_config_set_stdin_bytes#5179
Merged
Merged
Conversation
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Nov 2, 2022
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for this! One small nit on the C side but otherwise I think this might also need a cargo fmt to pass CI.
| * | ||
| * This function takes ownership of the `binary` argument. | ||
| */ | ||
| WASI_API_EXTERN void wasi_config_set_stdin_bytes(wasi_config_t* config, const wasm_byte_vec_t* binary); |
Member
There was a problem hiding this comment.
Since this takes owneship of the argument here I think it might be good to drop the const qualifier since it's actually mutated.
87a64dd to
ca1a1c5
Compare
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #4372 and respective issues about python and go bindings.
Can replace
wasi_config_inherit_stdinin examples/wasi/main.c:78(cc @alexcrichton)