Change the return type of SharedMemory::data#5240
Merged
Merged
Conversation
This commit is an attempt at improving the safety of using the return value of the `SharedMemory::data` method. Previously this returned `*mut [u8]` which, while correct, is unwieldy and unsafe to work with. The new return value of `&[UnsafeCell<u8>]` has a few advantages: * The lifetime of the returned data is now connected to the `SharedMemory` itself, removing the possibility for a class of errors of accidentally using the prior `*mut [u8]` beyond its original lifetime. * It's not possibly to safely access `.len()` as opposed to requiring an `unsafe` dereference before. * The data internally within the slice is now what retains the `unsafe` bits, namely indicating that accessing any memory inside of the contents returned is `unsafe` but addressing it is safe. I was inspired by the `wiggle`-based discussion on bytecodealliance#5229 and felt it appropriate to apply a similar change here.
github-actions
Bot
added
fuzzing
Subscribe to Label Actioncc @fitzgen, @peterhuene DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is an attempt at improving the safety of using the return value of the
SharedMemory::datamethod. Previously this returned*mut [u8]which, while correct, is unwieldy and unsafe to work with. The new return value of&[UnsafeCell<u8>]has a few advantages:The lifetime of the returned data is now connected to the
SharedMemoryitself, removing the possibility for a class of errors of accidentally using the prior*mut [u8]beyond its original lifetime.It's now possibly to safely access
.len()as opposed to requiring anunsafedereference before.The data internally within the slice is now what retains the
unsafebits, namely indicating that accessing any memory inside of the contents returned isunsafebut addressing it is safe.I was inspired by the
wiggle-based discussion on #5229 and felt it appropriate to apply a similar change here.