Skip to content

Flush icache on android aarch64 and unbreak Android compilation#5362

Merged
alexcrichton merged 1 commit into
bytecodealliance:release-3.0.0from
bnjbvr:flush-icache-release-3.0.0
Dec 1, 2022
Merged

Flush icache on android aarch64 and unbreak Android compilation#5362
alexcrichton merged 1 commit into
bytecodealliance:release-3.0.0from
bnjbvr:flush-icache-release-3.0.0

Conversation

@bnjbvr
Copy link
Copy Markdown
Member

@bnjbvr bnjbvr commented Dec 1, 2022

This is a backport of #5331 in the 3.0.0 branch, and it unblocks compiling on Android and FreeBSD.

@bjorn3
Copy link
Copy Markdown
Contributor

bjorn3 commented Dec 1, 2022

Thanks for including #5323 too!

@alexcrichton
Copy link
Copy Markdown
Member

Would you also be up for adding some release notes here and sending that to main as well?

@alexcrichton
Copy link
Copy Markdown
Member

Ah I'll take care of that in #5363

@alexcrichton alexcrichton merged commit 5f46815 into bytecodealliance:release-3.0.0 Dec 1, 2022
@alexcrichton
Copy link
Copy Markdown
Member

I'll note though that Android/FreeBSD aren't officially supported platforms or don't have CI in any way. This sort of breakage is bound to continue happening and it would be best I think if we didn't have to do point releases after-the-fact. If @bnjbvr or others would be willing to at least add cargo check for these platforms I think that would be the best course of action.

@bnjbvr bnjbvr deleted the flush-icache-release-3.0.0 branch December 1, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants