--json option for wasmtime settings command#5411
Merged
alexcrichton merged 7 commits intoDec 12, 2022
Merged
Conversation
- Refactored gathering of data into a `Settings` struct which can be used in both human/machine readable paths - Split out human readable output to another function, it produces exactly the same result as before
…e of not needing any extra dependencies (i.e.serde), but is obviously a bit ugly.
Contributor
Author
|
I'm not quite sure what the |
Contributor
|
Ah, you picked newer versions of serde and serde-json than we're using in the rest of the project, and nobody has vetted those versions or their dependencies yet. If you switch to serde 1.0.94 and serde_json 1.0.26, I believe all the cargo deny/vet errors will go away. |
Contributor
Author
|
Thanks, I'll try that. |
Contributor
|
I think you'll need to re-run cargo to update |
Contributor
Author
|
Looks like CI is passing this time, thanks for your help @jameysharp ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
--jsonflag to thewasmtime settingscommand, as discussed in #5404. Settings data is gathered into theSettingsstruct, which is then printed either in human readable form (exactly the same format as before) or JSON (using serde).I'm not very familiar with Rust, so please tell me if I've done any weird non-idiomatic things and I'll try to fix them!