Revert "Cranelift: Rewrite or(and(x, y), not(y)) => or(x, not(y))"#5682
Merged
Conversation
cfallin
approved these changes
Feb 1, 2023
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
LGTM in case this turns green and is the fix.
github-actions
Bot
added
the
cranelift
fitzgen
added a commit
to fitzgen/wasmtime
that referenced
this pull request
Feb 1, 2023
This rewrite was introduced in bytecodealliance#5676 and then reverted in bytecodealliance#5682 due to a footgun where we accidentally weren't actually checking the `y == !z` precondition. This commit fixes the precondition check. This reverts commit 268f6bf.
fitzgen
added a commit
to fitzgen/wasmtime
that referenced
this pull request
Feb 1, 2023
This rewrite was introduced in bytecodealliance#5676 and then reverted in bytecodealliance#5682 due to a footgun where we accidentally weren't actually checking the `y == !z` precondition. This commit fixes the precondition check. This reverts commit 268f6bf.
fitzgen
added a commit
to fitzgen/wasmtime
that referenced
this pull request
Feb 1, 2023
This rewrite was introduced in bytecodealliance#5676 and then reverted in bytecodealliance#5682 due to a footgun where we accidentally weren't actually checking the `y == !z` precondition. This commit fixes the precondition check. It also fixes the arithmetic to be correctly masked to the value type's width. This reverts commit 268f6bf.
fitzgen
added a commit
that referenced
this pull request
Feb 1, 2023
) This rewrite was introduced in #5676 and then reverted in #5682 due to a footgun where we accidentally weren't actually checking the `y == !z` precondition. This commit fixes the precondition check. It also fixes the arithmetic to be correctly masked to the value type's width. This reverts commit 268f6bf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5676
Fixes #5680.