Skip to content

Cranelift: Collapse double extends into a single extend #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 1 commit into from
Feb 13, 2023
Merged

Cranelift: Collapse double extends into a single extend #5772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cranelift/codegen/src/opts/algebraic.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
;; than a piece of the input or a new node that we construct; but we
;; can freely rewrite e.g. `x+y-y` to `x`.

;; Chained `uextend` and `sextend`.
(rule (simplify (uextend ty (uextend _intermediate_ty x)))
(uextend ty x))
(rule (simplify (sextend ty (sextend _intermediate_ty x)))
(sextend ty x))

;; x+0 == 0+x == x.
(rule (simplify (iadd ty
x
Expand Down
20 changes: 20 additions & 0 deletions cranelift/filetests/filetests/egraph/algebraic.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,3 +337,23 @@ block0(v1: i32):

; check: v5 = iconst.i8 1
; check: return v5

function %double_uextend(i16) -> i64 {
block0(v1: i16):
v2 = uextend.i32 v1
v3 = uextend.i64 v2
return v3
}

; check: v4 = uextend.i64 v1
; check: return v4

function %double_sextend(i16) -> i64 {
block0(v1: i16):
v2 = sextend.i32 v1
v3 = sextend.i64 v2
return v3
}

; check: v4 = sextend.i64 v1
; check: return v4