Skip to content

clif: Remove the type variable from swizzle#5897

Merged
cfallin merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:swizzle-not-generic
Mar 1, 2023
Merged

clif: Remove the type variable from swizzle#5897
cfallin merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:swizzle-not-generic

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

This instruction is only defined with i8x16 inputs and outputs so there's no need for a type variable, so shadow the otherwise-generic a result with a concrete i8x16 type.

This instruction is only defined with i8x16 inputs and outputs so
there's no need for a type variable, so shadow the otherwise-generic `a`
result with a concrete i8x16 type.
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. cranelift:wasm labels Feb 28, 2023
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cfallin cfallin added this pull request to the merge queue Mar 1, 2023
Merged via the queue into bytecodealliance:main with commit c4a2c1e Mar 1, 2023
@alexcrichton alexcrichton deleted the swizzle-not-generic branch March 28, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:meta Everything related to the meta-language. cranelift:wasm cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants