craneleft: cancel ineg when args to imul#6053
Merged
Merged
Conversation
auto-merge was automatically disabled
March 17, 2023 19:14
Head branch was pushed to by a user without write access
Kmeakin
changed the title
ineg/iabs when args to imulineg when args to imul
Contributor
Author
|
Realised |
Member
|
Removing from queue due to above, and I'll give it a second review |
cfallin
approved these changes
Mar 17, 2023
Member
|
All that's left now is the optimization in the description, which LGTM! |
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.