Cranelift: ISLE: aarch64: fix imm12_from_negated_value for i32, i16#6078
Merged
Conversation
github-actions
Bot
added
cranelift
cfallin
approved these changes
Mar 21, 2023
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
This makes sense to me -- thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5903
This fixes
imm12_from_negated_valueto correctly sign-extend narrow values before negating them asi64values, allowing these rules to work for non-zero negativei32andi16.As suggested by @jameysharp in that issue, switch
imm12_from_negated_valueto be a partial term with a corresponding rule.Also updated + added to the relevant filetest.