x64: Add AVX support for some more float-related instructions#6092
Merged
Conversation
Additionally update the instruction helpers to take an `XmmMem` argument to allow load sinking into the instruction.
github-actions
Bot
added
cranelift
abrown
approved these changes
Mar 29, 2023
| // reflected in the CLIF instruction, however, since the SSE version | ||
| // doesn't have this functionality. Instead just copy whatever | ||
| // happens to already be in the destination, which at least is what | ||
| // LLVM seems to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds AVX support for
vsqrts{s,d},vrounds{s,d}, andvcvt{ss2sd,sd2ss}. After this I think thatXmmCmpRmRis the only remaining non-VEX instruction, which I hope to tackle next.